Add LogicAppTestRunner and replace Controller#18150
Merged
vidai-msft merged 2 commits intoAzure:mainfrom May 13, 2022
Merged
Conversation
vidai-msft
requested changes
May 13, 2022
| public class CreateLogicAppTests : LogicAppUnitTestBase | ||
| { | ||
| public CreateLogicAppTests(ITestOutputHelper output) | ||
| public CreateLogicAppTests(ITestOutputHelper output) : base(output) |
Contributor
There was a problem hiding this comment.
For unit test, just keep as it is
| /// Base class for the Logic app command tests | ||
| /// </summary> | ||
| public class LogicAppUnitTestBase : RMTestBase | ||
| public class LogicAppUnitTestBase : LogicAppTestRunner |
Contributor
There was a problem hiding this comment.
For unit test, just keep as it is. No need to make it inherit from TestRunner
vidai-msft
approved these changes
May 13, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add LogicAppTestRunner and replace Controller
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added